clear-pr-merge-commit-message preserve closing issues on non-default branch
#6122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
reviewed
Nov 1, 2022
Co-authored-by: Federico Brigante <[email protected]>
fregante
reviewed
Nov 1, 2022
fregante
approved these changes
Nov 1, 2022
|
|
||
| const issueNumberElement = keyword.nextElementSibling as HTMLAnchorElement; | ||
| const isCrossRepo = getRepo(issueNumberElement)!.nameWithOwner !== getRepo()!.nameWithOwner; | ||
| const issueNumber = isCrossRepo ? issueNumberElement.href : issueNumberElement.textContent!; |
There was a problem hiding this comment.
What if we just get the whole URL? fixes https://GitHub.com/user/repo/issues/123
It works regardless of the repo. I'm not particularly worried about this scenario to be honest because the users who want this specific behavior can just disable the feature and user GitHub's own repo config.
Fixing it is ok, but having a clean fixes #124 isn't worth the complexity here.
fregante
added a commit
to refined-github/sandbox
that referenced
this pull request
Feb 11, 2023
Resolves refined-github/refined-github#6122 Closes #51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4531
Test URLs
refined-github/sandbox#53
Screenshot