Meta: Use new APIs in update-pr-from-base-branch

[yakov116]

Test URLs

refined-github/sandbox#9 (Conflict)
refined-github/sandbox#11

Screenshot

NA

[yakov116]

@busches will this affect GHE?

[busches]

@yakov116 you can check the GHE docs to see what, if any, versions support it yet. Guessing it's not in any version yet.

[fregante]

@yakov116 we have probably never waited for GHE to use updated APIs

[yakov116]

This will break the entire feature, since the api call will fail.

I don't remember in the past ever having a case where an API was not available on GHE.

However I do remember holding off on v4 until GHE had normal support.

I am not waiting to support the API I am just using a fallback.

[busches]

I do use this feature all the time, so I appreciate the thought. 😃

[fregante]

You can merge these into flat object, no need to have prInfo and comparison keys. While we're at it it can be simplified further, like setting diverged: true instead of matching strings outside

[yakov116]

While we're at it it can be simplified further, like setting diverged: true instead of matching strings outside

Can you explain this one more time I am not sure I understood what you said

[fregante]

This just mixes the logic of a specific feature with this generic get pr info function, which could return the PR info regardless of the need to update the PR.

I suggested returning diverged: true for both API calls, i.e. something like

Suggested change

	if (repository.pullRequest.headRef.compare.status !== 'DIVERGED') {
	return;
	}
	return repository.pullRequest;
	return {
	...repository.pullRequest,
	diverged: repository.pullRequest.headRef.compare.status === 'DIVERGED'
	};

And the logic just checks pr.diverged, or better yet pr.needsUpdate as a combination of mergeable and diverged

---

I suppose it's ok as is for now if it's tested, but it'll need to be changed eventually. 👍