Lint #5902
Lint #5902
Conversation
Can't stand this senseless name anymore
It pushed the "New issue" down by 2px on https://github.com/refined-github/refined-github/issues
| - [Awesome browser extensions for GitHub](https://github.com/stefanbuck/awesome-browser-extensions-for-github) - Awesome list | ||
| - [OctoLinker](https://github.com/OctoLinker/OctoLinker) - Navigate across files and packages | ||
| - [Notifier for GitHub](https://github.com/sindresorhus/notifier-for-github-chrome) - Shows your notification unread count | ||
| - [Mottie's Userscripts](https://github.com/Mottie/GitHub-userscripts) - Countless features to improve GitHub granularly | ||
| - [Contributors on GitHub](https://github.com/hzoo/contributors-on-github) - Shows stats about contributors | ||
| - [Hide Files on GitHub](https://github.com/sindresorhus/hide-files-on-github) - Hides dotfiles from the file browser | ||
| - [GitHub Issue Link Status](https://github.com/fregante/github-issue-link-status) - Colorize issue and PR links to see their status (open, closed, merged) | ||
| - [Notifications Preview for GitHub](https://github.com/tanmayrajani/notifications-preview-github) - See your notifications on hover on all pages | ||
| - [Show All GitHub Issues](https://github.com/sindresorhus/show-all-github-issues) - Shows both Issues and Pull Requests in the Issues tab | ||
| - [Sourcegraph](https://github.com/sourcegraph/sourcegraph/tree/main/client/browser) - Code search and navigation tool | ||
| - [PR Monitor](https://github.com/fwouts/prmonitor) - Notifies you about incoming and outgoing PRs |
There was a problem hiding this comment.
Neat! I always find this part a little bit weird, we are not talking about two or three but (almost) a dozen 😅 .
As suggested in #5787
source/features/clean-repo-tabs.tsx
Outdated
| @@ -116,7 +112,7 @@ async function initProjects(): Promise<void | false> { | |||
| return; | |||
| } | |||
|
|
|||
| if (await canUserEditOrganization()) { | |||
| if (pageDetect.isUserTheOrganizationOwner()) { | |||
There was a problem hiding this comment.
canUserEditOrganization was renamed in the package because it was incorrect, but this is not the same as isUserTheOrganizationOwner
- Rename
canUserEditOrganizationtoisUserTheOrganizationOwnergithub-url-detection#87 - Add
remove-unused-repo-tabsfeature #4534 (comment)
If anything, we need to add canUserEditOrganization () => select.exists('.btn-primary[href$="repositories/new"]'). We didn't back then because we needed elementReady, which isn't yet available:
There was a problem hiding this comment.
Thanks for explaining, I'm confused as I think if a user can edit organization, they are certainly a owner. Now that I take a look at the actual selector, I think this should be named something else than canUserEditOrganization.
Being able to create a repo only means they have org-wide write access. As an example, the existing canUserEditRepo is checking for a settings tab, which only exists for those who can manage the repo, not just write access.
|
This PR is ready to go 🚀 Feel free to open a new one as needed |
No description provided.