Don't show single non-boundary spaces in show-whitespace
#5709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
changed the title
show-whitespace
fregante
commented
Jun 20, 2022
source/features/show-whitespace.tsx
Outdated
| @@ -21,26 +21,38 @@ function showWhiteSpacesOn(line: Element): void { | |||
| continue; | |||
| } | |||
|
|
|||
| const startingCharacter = shouldAvoidSurroundingSpaces && nodeIndex === 0 ? 1 : 0; | |||
| const skipLastCharacter = shouldAvoidSurroundingSpaces && nodeIndex === textNodesOnThisLine.length - 1; | |||
| // This referes to the boundary text nodes, not actual whitespace nodes. Text nodes are generated by the syntax highlighter, so non-highlighted text will have one text node. | |||
There was a problem hiding this comment.
Not that this PR doesn't change how the feature behaves on non-highlighted pre like
hello world
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
fregante
force-pushed
the
only-trailing-whitespace
branch
from
60a0ae8
to
a333751
Compare
This comment was marked as resolved.
This comment was marked as resolved.
fregante
changed the title
show-whitespaceshow-whitespace
|
If I remember correctly this was my only complaint when we added this feature. |
|
Let's just hope I didn't break the feature further 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test URLs
show-whitespacesandbox#18Before
After