Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive box shadow in dark mode #7305

Closed
willdurand opened this issue Mar 19, 2024 · 2 comments · Fixed by #7306
Closed

Excessive box shadow in dark mode #7305

willdurand opened this issue Mar 19, 2024 · 2 comments · Fixed by #7306
Labels

Comments

@willdurand
Copy link

willdurand commented Mar 19, 2024

Description

In dark mode on Firefox Release 124, when navigating to https://github.com/notifications, there is a new excessive box shadow added by this style:

.Box:has(.js-notifications-mark-all-prompt) {

Screenshot 2024-03-19 at 21 18 49

I just updated from Firefox 123 to 124, I am not sure the add-on has been updated along the way (I doubt it since the add-on was last updated a month ago). Nothing else has changed.

How to replicate the issue + URL

Browse https://github.com/notifications in dark mode on Firefox Release 124.

Extension version

24.2.8

Browser(s) used

Firefox Release 124.0

@willdurand willdurand added the bug label Mar 19, 2024
@jdreesen
Copy link

I think it's GitHub that changed. Several plugins broke today.

Possibly a duplicate of #7304.

@tjhorner
Copy link

Confirmed on Chrome 122.0.6261.129 too and it appears the shadow is added by the same declaration @willdurand linked

image

@fregante fregante closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
@fregante fregante reopened this Mar 20, 2024
@fregante fregante changed the title Excessive box shadow in dark mode in Firefox (124) Excessive box shadow in dark mode Mar 20, 2024
fregante added a commit to refined-github/yolo that referenced this issue Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

4 participants