Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unwrap-unnecessary-dropdowns errors on notifications page #7304

Open
connorjclark opened this issue Mar 19, 2024 · 3 comments
Open

unwrap-unnecessary-dropdowns errors on notifications page #7304

connorjclark opened this issue Mar 19, 2024 · 3 comments
Labels

Comments

@connorjclark
Copy link

connorjclark commented Mar 19, 2024

Description

https://github.com/refined-github/refined-github/assets/4071474/d740ef96-e003-4d8d-b0cf-8633c25b3f90

 unwrap-unnecessary-dropdowns
refined-github.js:4009 πŸ“• 24.2.8 β†’ TypeError: Cannot read properties of undefined (reading 'textContent')
    at init (refined-github.js:9507:139)
    at async refined-github.js:4060:22
    at async Promise.all (index 0)
    at async refined-github.js:4056:11
    at async runFeature (refined-github.js:4055:9)
    at async setupPageLoad (refined-github.js:4072:37)

How to replicate the issue + URL

just go to https://github.com/notifications . You'll need at least one notification to see the Select All header.

Extension version

24.2.8

Browser(s) used

123.0.6312.46 (Official Build) (arm64)

@blakegearin
Copy link

Even with unwrap-unnecessary-dropdowns disabled I'm still seeing the large box-shadow that wasn't there yesterday.

Looks like it's coming from sticky-notifications-actions. --rgh-background is white when it used to be a dark color.

@jdreesen
Copy link

jdreesen commented Mar 19, 2024

Yes, it seems that GitHub has made some major changes that have broken many addons :/

@fregante
Copy link
Member

I left the shadow issue in #7305

The console error for unwrap-unnecessary-dropdowns is unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants