Lint (#6555)

source/feature-manager.tsx

@@ -10,7 +10,6 @@ import onAbort from './helpers/abort-controller';
 import ArrayMap from './helpers/map-of-arrays';
 import bisectFeatures from './helpers/bisect';
 import {shouldFeatureRun} from './github-helpers';
-import polyfillTurboEvents from './github-helpers/turbo-events-polyfill';
 import optionsStorage, {RGHOptions} from './options-storage';
 import {
  applyStyleHotfixes,
@@ -151,8 +150,6 @@ const globalReady = new Promise<RGHOptions>(async resolve => {
  features.log.error = () => {/* No logging */};
  }
 
- polyfillTurboEvents();
-
  resolve(options);
 });
 

source/features/bypass-checks.tsx

@@ -13,7 +13,7 @@ async function bypass(detailsLink: HTMLAnchorElement): Promise<void> {
  return;
  }
 
- // TODO: Use v4: https://docs.github.com/en/graphql/reference/objects#checkrun
+ // Impossible with v4 https://github.com/refined-github/refined-github/pull/6550#discussion_r1176346110
  const {details_url: detailsUrl} = await api.v3(`check-runs/${runId}`);
  if (!detailsUrl) {
  return;

source/features/clear-pr-merge-commit-message.tsx

@@ -39,21 +39,21 @@ async function init(): Promise<void | false> {
 }
 
 void features.add(import.meta.url, {
+ asLongAs: [
+ userCanLikelyMergePR,
+ ],
  include: [
  pageDetect.isPRConversation,
  ],
  exclude: [
  // Don't clear 1-commit PRs #3140
  () => select.all('.TimelineItem.js-commit').length === 1,
  ],
- asLongAs: [
- userCanLikelyMergePR,
- ],
  additionalListeners: [
  onPrMergePanelOpen,
  ],
  onlyAdditionalListeners: true,
- awaitDomReady: true, // Appears near the page anyway
+ awaitDomReady: true, // Appears near the end of the page anyway
  init,
 });
 

source/features/conversation-activity-filter.tsx

@@ -189,7 +189,6 @@ async function addWidget(header: string, state: State): Promise<void> {
 }
 
 const minorFixesIssuePages = [
- 'https://github.com/refined-github/refined-github/issues/5222',
  'https://github.com/refined-github/refined-github/issues/3686',
  'https://github.com/refined-github/refined-github/issues/6000',
 ];

source/features/enable-file-links-in-compare-view.tsx

@@ -79,3 +79,12 @@ void features.add(import.meta.url, {
  awaitDomReady: true, // DOM-based filters
  init,
 });
+
+/*
+
+Test URLs
+
+- Open PR: https://github.com/refined-github/sandbox/pull/4/files
+- Compare view: https://github.com/refined-github/sandbox/compare/default-a...very-very-long-long-long-long-branch-name
+
+*/

source/features/link-to-github-io.tsx

@@ -38,12 +38,12 @@ function initRepoList(signal: AbortSignal): void {
 }
 
 void features.add(import.meta.url, {
- include: [
- pageDetect.hasRepoHeader,
- ],
  asLongAs: [
  () => /\.github\.(io|com)$/.test(getRepo()?.name ?? 'shush eslint'),
  ],
+ include: [
+ pageDetect.hasRepoHeader,
+ ],
  init: initRepo,
 }, {
  include: [

source/features/linkify-user-labels.tsx

@@ -26,12 +26,12 @@ function init(signal: AbortSignal): void {
 }
 
 void features.add(import.meta.url, {
- include: [
- pageDetect.hasComments,
- ],
  asLongAs: [
  pageDetect.isRepo,
  ],
+ include: [
+ pageDetect.hasComments,
+ ],
  init,
 });
 

source/features/sync-pr-commit-title.tsx

@@ -89,12 +89,12 @@ function init(signal: AbortSignal): void {
 }
 
 void features.add(import.meta.url, {
- include: [
- pageDetect.isPRConversation,
- ],
  asLongAs: [
  userCanLikelyMergePR,
  ],
+ include: [
+ pageDetect.isPRConversation,
+ ],
  awaitDomReady: true, // DOM-based filters, feature appears at the end of the page
  init,
 });

source/globals.d.ts

@@ -80,3 +80,7 @@ declare module 'react' {
 interface Node extends EventTarget {
  cloneNode(deep?: boolean): this;
 }
+
+interface SignalAsOptions {
+ signal?: AbortSignal;
+}

source/helpers/selector-observer.tsx

@@ -6,8 +6,18 @@ import {ParseSelector} from 'typed-query-selector/parser';
 import getCallerID from './caller-id';
 import isDevelopmentVersion from './is-development-version';
 
+type ObserverListener<ExpectedElement extends Element> = (element: ExpectedElement, options: SignalAsOptions) => void;
+
 const animation = 'rgh-selector-observer';
-const getListener = <ExpectedElement extends HTMLElement>(seenMark: string, selector: string, callback: (element: ExpectedElement) => void) => function (event: AnimationEvent) {
+const getListener = <
+ Selector extends string,
+ ExpectedElement extends ParseSelector<Selector, HTMLElement>,
+>(
+ seenMark: string,
+ selector: Selector,
+ callback: ObserverListener<ExpectedElement>,
+ signal?: AbortSignal,
+) => function (event: AnimationEvent) {
  const target = event.target as ExpectedElement;
  // The target can match a selector even if the animation actually happened on a ::before pseudo-element, so it needs an explicit exclusion here
  if (target.classList.contains(seenMark) || !target.matches(selector)) {
@@ -17,7 +27,7 @@ const getListener = <ExpectedElement extends HTMLElement>(seenMark: string, sele
  // Removes this specific selector’s animation once it was seen
  target.classList.add(seenMark);
 
- callback(target);
+ callback(target, {signal});
 };
 
 const registerAnimation = onetime((): void => {
@@ -26,10 +36,11 @@ const registerAnimation = onetime((): void => {
 
 export default function observe<
  Selector extends string,
+ ExpectedElement extends ParseSelector<Selector, HTMLElement>,
 >(
  selectors: Selector | readonly Selector[],
- listener: (element: ParseSelector<Selector, HTMLElement>) => void,
- {signal}: {signal?: AbortSignal} = {},
+ listener: ObserverListener<ExpectedElement>,
+ {signal}: SignalAsOptions = {},
 ): void {
  if (signal?.aborted) {
  return;
@@ -55,5 +66,5 @@ export default function observe<
  signal?.addEventListener('abort', () => {
  rule.remove();
  });
- window.addEventListener('animationstart', getListener(seenMark, selector, listener), {signal});
+ window.addEventListener('animationstart', getListener(seenMark, selector, listener, signal), {signal});
 }