Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include /dashboard-feed in isDashboard #187

Merged
merged 9 commits into from Sep 28, 2023
Merged

Include /dashboard-feed in isDashboard #187

merged 9 commits into from Sep 28, 2023

Conversation

port19x
Copy link
Contributor

@port19x port19x commented Sep 12, 2023

I've never written javascript or typescript, but if I don't grossly misunderstand the semantics here my PR should work.

fixes #186

@port19x
Copy link
Contributor Author

port19x commented Sep 12, 2023

Nice CI pipeline, got some fixes to do

@port19x
Copy link
Contributor Author

port19x commented Sep 12, 2023

I see, lockfile complains. Gotta install npm 🚶

Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

index.ts Outdated Show resolved Hide resolved
@port19x
Copy link
Contributor Author

port19x commented Sep 12, 2023

Should I squash?

@fregante
Copy link
Member

Not necessary, GitHub will squash on merge

@fregante
Copy link
Member

Ouch I forgot to publish this earlier 🥲
It'll appear in the next version of Refined GitHub

@fregante fregante merged commit 6ed1e73 into refined-github:main Sep 28, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add /dashboard-feed to isDashboard?
2 participants