-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minor issues in docs #675
Open
aryaemami59
wants to merge
54
commits into
reduxjs:master
Choose a base branch
from
aryaemami59:fix-docs
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+680
−600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This change was made to emphasize the switch from `lruMemoize` to `weakMapMemoize` inside `createSelector`
…he transition in `createSelector` - Revised content to clearly emphasize the change from using `lruMemoize` to `weakMapMemoize` as the default memoizer in `createSelector` starting from Reselect 5.0.0.
✅ Deploy Preview for reselect-docs canceled.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
…ranch 'master' of https://github.com/reduxjs/reselect into fix-docs
FYI I will probably split this into 2 PRs, one for docs, one for JSDocs. |
I haven't forgotten about this one, since it's actually important, will probably finish it sometime this week. |
This reverts commit c8e46cf.
This reverts commit 16f1ff6.
This reverts commit c80175e.
This reverts commit a7ab21a.
This reverts commit aea5199.
… first overload" This reverts commit 9c2f541.
This reverts commit 684b00a.
This reverts commit bfbdba5.
This reverts commit d1799a6.
This reverts commit b3dce8f.
This should be it for now, if I think of anything else, I'll open a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
createSelectorCreator
Parameters inside docsREADME
filelruMemoize
toweakMapMemoize
insidecreateSelector
lruMemoize
andweakMapMemoize
documentation to clearly emphasize the change from usinglruMemoize
toweakMapMemoize
as the default memoizer increateSelector
starting from Reselect 5.0.0.