⬆️ Bump Docusaurus to 2.0 beta 7 #4193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ea4055c:
|
Shrugsy
force-pushed
the
docs/update-docusaurus
branch
from
a3ffa1d
to
ea4055c
Compare
|
✔️ Deploy Preview for redux-docs ready! 🔨 Explore the source changes: a3ffa1d 🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-docs/deploys/616db1ec1cb4020007f59731 😎 Browse the preview: https://deploy-preview-4193--redux-docs.netlify.app |
|
✔️ Deploy Preview for redux-docs ready! 🔨 Explore the source changes: ea4055c 🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-docs/deploys/616dbb24d1bf34062a0ba22b 😎 Browse the preview: https://deploy-preview-4193--redux-docs.netlify.app |
|
Yep, that looks to fix it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: 📝 Documentation Fix
about: Fixing a problem in an existing docs page
Checklist
What docs page needs to be fixed?
What is the problem?
Certain sidebar items get obscured after expanding. Reproducibility depends on browser size.
What changes does this PR make to fix the problem?
Takes advantage of facebook/docusaurus#5694 which specifically referenced the redux docs when fixing the issue
Note also that this will address page shifting when toggling between TS/JS snippet tabs, which would occur if #4149 is merged.
i.e. @timdorr it would specifically address your concern in this comment: #4112 (comment)
See reduxjs/redux-toolkit#1620 (comment) for an example of how the page shifting is addressed.