Changes to variable-ize the runtime-hook and cuda repos. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the container-runtime-hook and cuda driver installation to use variable-based repository definitions via switching to the
yum_repositoryansible module instead of directly consuming either the NVIDIA repo definitions or the repo RPM.The defaults are set to what comes directly from NVIDIA's repo defs/RPMs. But this allows one to substitute their own package mirror.
This change is useful for those who want to ensure that upstream changes do not break any automation or expected behaviors. NVIDIA's recent changes, as an example, to the driver RPMs for cuda caused these playbooks to fail when directly ran against the NVIDIA repos. If one was using a mirror, they would've been isolated from those changes.