Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor concat instead of append #2085

Closed
wants to merge 142 commits into from
Closed

Refactor concat instead of append #2085

wants to merge 142 commits into from

Conversation

gogetron
Copy link

@gogetron gogetron commented Apr 10, 2024 •
edited

Description

Addresses #2023

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • I have signed the commits, e.g. git commit -s -m "your commit message".
  • This PR is being made to staging branch AND NOT TO main branch.

miguelgfierro
miguelgfierro approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

miguelgfierro and others added 22 commits April 11, 2024 11:22
@miguelgfierro @gogetron
📝
6daa1fc 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
📝 remove papermill and scrapbook references
0dd6ec6 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
📝 remove papermill and scrapbook references
e02a2b4 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
📝
7ef34f4 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
📝 remove papermill and scrapbook references
0387021 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
📝 remove papermill and scrapbook references
fe25461 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
📝 remove papermill and scrapbook references
4d5c1d8 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
📝
7182327 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
Updated PR template
f01fa48 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
Updated contributing
d55f31d 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
Updated PR template and contributing
5d2e03d 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
Updated contributing
04c4f2b 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@thaiminhpv @gogetron
[Fix] correct MIND data construction of user behavior history
0883f6d 
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
change path hybrid
f6b7254 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
Update hybrid to CF
9526dec 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
change path hybrid
97e0f20 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
change path hybrid
8579a69 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
📝
38e78ed 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
Creating a jupyter book
913a58d 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
Creating documentation
03c1640 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
📝
387185e 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
WIP
4f5d139 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
SimonYansenZhao and others added 27 commits April 11, 2024 11:27
@SimonYansenZhao @gogetron
Correct the usage of torch.column_stack()
cb73b6b 
Signed-off-by: martin <[email protected]>
@SimonYansenZhao @gogetron
Correct conversion from tensor to numpy
148453d 
Signed-off-by: martin <[email protected]>
@SimonYansenZhao @gogetron
Remove duplicate dependencies jinja2 and packaging required other pac…
a270ce7 
…kages
@SimonYansenZhao @gogetron
Try Python 3.11
ee4945a
@SimonYansenZhao @gogetron
Allow Python 3.11 for sarplus
4c1c14a 
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
Rerun and fix fastai movielens notebook
8e61bdf 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
Fixed deprecated attribute in fastai
9b586d9 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
Fixing breaking changes in fastai
2f4a031 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@SimonYansenZhao @gogetron
Upgrade GitHub Action azure/login
22e4998 
Signed-off-by: martin <[email protected]>
@SimonYansenZhao @gogetron
Update fastai usage in utils
ae7e625 
Signed-off-by: martin <[email protected]>
@loomlike @gogetron
change deprecated azureml option (recommenders-team#2069)
482e879 
Signed-off-by: Jun Ki Min <[email protected]>
@loomlike @gogetron
Update SP creation doc
d0604f7 
Signed-off-by: Jun Ki Min <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
📝
d82804c 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
Fixing TF to < 2.16
cc4ba2c 
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
🐛
a471189 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
model to CUDA as well as data
7938241 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@SimonYansenZhao @gogetron
Set tensorflow <= 2.15.0
7e6394c 
Signed-off-by: Simon Zhao <[email protected]>
@SimonYansenZhao @gogetron
Add missing colon
37a68bb 
Signed-off-by: Simon Zhao <[email protected]>
@miguelgfierro @gogetron
📝
edb931f 
Signed-off-by: miguelgfierro <[email protected]>
@miguelgfierro @gogetron
Reducing DKN batch size to 200
ec6db85 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@SimonYansenZhao @gogetron
Move learner.model to cuda if cuda is available
7a4f2b3 
Signed-off-by: Simon Zhao <[email protected]>
@daviddavo @gogetron
Merged two concats into one
2e06cd8 
Signed-off-by: David Davó <[email protected]>
Signed-off-by: martin <[email protected]>
@daviddavo @gogetron
Further simplified merge
2c599a3 
Signed-off-by: David Davó <[email protected]>
Signed-off-by: martin <[email protected]>
@SimonYansenZhao @gogetron
Catch import error separately for SUMModel
c751c50 
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: martin <[email protected]>
@miguelgfierro @gogetron
Reco book update
6e7f383 
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: martin <[email protected]>
@gogetron
Refactor: pd.concat instead of frame append
d7e1a2b 
Signed-off-by: martin <[email protected]>
@gogetron
Perf: use loc instead of concat
848f456 
Signed-off-by: martin <[email protected]>
@gogetron gogetron force-pushed the refactor-concat-instead-of-append branch from cc157b8 to 848f456 Compare April 11, 2024 10:30
@gogetron gogetron closed this Apr 11, 2024
@gogetron gogetron deleted the refactor-concat-instead-of-append branch April 11, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviddavo daviddavo daviddavo left review comments

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

@SimonYansenZhao SimonYansenZhao Awaiting requested review from SimonYansenZhao SimonYansenZhao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@gogetron @miguelgfierro @daviddavo @thaiminhpv @simonzhaoms @SimonYansenZhao @anargyri @gazon1 @loomlike