Refactor tests into new categories reviewed by Eric Gamma #1989

miguelgfierro · 2023-09-07T08:55:59Z

Description

Relocate the tests into folders following the new categories: https://github.com/recommenders-team/recommenders/tree/main/tests#categories-of-tests

Related Issues

#1986

References

Checklist:

I have followed the contribution guidelines and code style for this project.
I have added tests covering my contributions.
I have updated the documentation accordingly.
This PR is being made to staging branch and not to main branch.

Signed-off-by: miguelgfierro <[email protected]>

loomlike

this is great. any reason you created draft PR?

loomlike · 2023-09-12T00:08:42Z

tests/ci/azureml_tests/test_groups.py

 "tests/unit/recommenders/datasets/test_dataset.py::test_maybe_download_retry",
- "tests/unit/recommenders/datasets/test_movielens.py::test_mock_movielens_schema__get_df__return_success",
+ "tests/unit/recommenders/datasets/test_dataset.py::test_maybe_download_wrong_bytes",


I just found test_dataset.py file name is somewhat confusing. I created #1991 to track that.

fixed in the next commit

miguelgfierro · 2023-09-12T19:39:05Z

this is great. any reason you created draft PR?

just because it was WIP.

Signed-off-by: miguelgfierro <[email protected]>

miguelgfierro · 2023-09-16T05:07:38Z

Error when building the docker image. See https://github.com/recommenders-team/recommenders/actions/runs/6200886264/attempts/1


Execution Summary
=================
RunId: unit_tests_group_gpu_001_1694798021_bc46a23e
Web View: https://ml.azure.com/runs/unit_tests_group_gpu_001_1694798021_bc46a23e?wsid=/subscriptions/***/resourcegroups/recommenders_project_resources/workspaces/azureml-test-workspace&tid=***
Traceback (most recent call last):
  File "tests/ci/azureml_tests/submit_groupwise_azureml_pytest.py", line 468, in <module>
    run = submit_experiment_to_azureml(
  File "tests/ci/azureml_tests/submit_groupwise_azureml_pytest.py", line 269, in submit_experiment_to_azureml
    run.wait_for_completion(show_output=True, wait_post_processing=True)
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/azureml/core/run.py", line 849, in wait_for_completion
    self._stream_run_output(
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/azureml/core/run.py", line 1102, in _stream_run_output
    raise ActivityFailedException(error_details=json.dumps(error, indent=4))
azureml.exceptions._azureml_exception.ActivityFailedException: ActivityFailedException:
	Message: Activity Failed:
***
    "error": ***
        "code": "UserError",
        "message": "Image build failed. For more details, check log file azureml-logs/20_image_build_log.txt.",
        "messageFormat": "Image build failed. For more details, check log file ***ArtifactPath***.",
        "messageParameters": ***
            "ArtifactPath": "azureml-logs/20_image_build_log.txt"
        ***,
        "details": [],
        "innerError": ***
            "code": "BadArgument",
            "innerError": ***
                "code": "ImageBuildFailure"
            ***
        ***
    ***,
    "correlation": ***
        "operation": "192ec241356724a4716bb148b097495d",
        "request": "bbb00988d3dde4fd"
    ***,
    "environment": "eastus",
    "location": "eastus",
    "time": "2023-09-15T17:33:03.253113Z",
    "componentName": "RunHistory"
***
	InnerException None
	ErrorResponse 
***
    "error": ***
        "message": "Activity Failed:\n***\n    \"error\": ***\n        \"code\": \"UserError\",\n        \"message\": \"Image build failed. For more details, check log file azureml-logs/20_image_build_log.txt.\",\n        \"messageFormat\": \"Image build failed. For more details, check log file ***ArtifactPath***.\",\n        \"messageParameters\": ***\n            \"ArtifactPath\": \"azureml-logs/20_image_build_log.txt\"\n        ***,\n        \"details\": [],\n        \"innerError\": ***\n            \"code\": \"BadArgument\",\n            \"innerError\": ***\n                \"code\": \"ImageBuildFailure\"\n            ***\n        ***\n    ***,\n    \"correlation\": ***\n        \"operation\": \"192ec241356724a4716bb148b097495d\",\n        \"request\": \"bbb00988d3dde4fd\"\n    ***,\n    \"environment\": \"eastus\",\n    \"location\": \"eastus\",\n    \"time\": \"2023-09-15T17:33:03.253113Z\",\n    \"componentName\": \"RunHistory\"\n***"
    ***
***
Error: Process completed with exit code 1.

The second run worked. Sometimes, you just need to give the thingy time :-)

Signed-off-by: miguelgfierro <[email protected]>

miguelgfierro · 2023-09-16T17:24:57Z

FYI @SimonYansenZhao this shouldn't crash with the development of Python 3.10, it's more like a relocation of paths

Signed-off-by: miguelgfierro <[email protected]>

miguelgfierro · 2023-09-17T21:05:26Z

============================= test session starts ==============================
platform linux -- Python 3.8.16, pytest-7.4.2, pluggy-1.3.0
rootdir: /mnt/azureml/cr/j/136f15e8d32d4bbc8f0c09009929d765/exe/wd
configfile: pyproject.toml
plugins: hypothesis-6.86.1, anyio-4.0.0, mock-3.11.1, cov-4.1.0, typeguard-4.1.5
collected 207 items

tests/data_validation/recommenders/datasets/test_movielens.py .
..............
tests/data_validation/recommenders/datasets/test_wikidata.py .           [ 17%]
tests/unit/recommenders/datasets/test_download_utils.py ...
tests/unit/recommenders/datasets/test_pandas_df_utils.py ......          [ 22%]
tests/unit/recommenders/datasets/test_python_splitter.py .......         [ 26%]
tests/unit/recommenders/datasets/test_sparse.py ..                       [ 27%]
tests/unit/recommenders/evaluation/test_python_evaluation.py ........... [ 32%]
...................                                                      [ 41%]
tests/unit/recommenders/models/test_geoimc.py ..                         [ 42%]
tests/unit/recommenders/models/test_tfidf_utils.py ........              [ 46%]
tests/unit/recommenders/models/test_cornac_utils.py ..                   [ 47%]
tests/unit/recommenders/models/test_geoimc.py ..........                 [ 52%]
tests/unit/recommenders/models/test_lightfm_utils.py .Fatal Python error: Illegal instruction

Thread 0x0000146668753700 (most recent call first):
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/threading.py", line 306 in wait
Traceback (most recent call last):
  File "tests/ci/azureml_tests/submit_groupwise_azureml_pytest.py", line 468, in <module>
    run = submit_experiment_to_azureml(
  File "tests/ci/azureml_tests/submit_groupwise_azureml_pytest.py", line 269, in submit_experiment_to_azureml
    run.wait_for_completion(show_output=True, wait_post_processing=True)
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/azureml/core/run.py", line 849, in wait_for_completion
    self._stream_run_output(
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/azureml/core/run.py", line 1102, in _stream_run_output
    raise ActivityFailedException(error_details=json.dumps(error, indent=4))
azureml.exceptions._azureml_exception.ActivityFailedException: ActivityFailedException:
	Message: Activity Failed:
***
    "error": ***
        "code": "UserError",
        "message": "Execution failed. User process '/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/bin/python' terminated by signal 4. Please check log file 'user_logs/std_log.txt' for error details. Error:   File \"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_callers.py\", line 77 in _multicall\n  File \"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_manager.py\", line 115 in _hookexec\n  File \"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_hooks.py\", line 493 in __call__\n  File \"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/main.py\", line 350 in pytest_runtestloop\n  File \"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_callers.py\", line 77 in _multicall\n  File \"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_manager.py\", line 115 in _hookexec\n  File \"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_hooks.py\", line 493 in __call__\n  File \"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/main.py\", line 325 in _main\n  File \"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/main.py\", line 271 in wrap_session\n  File \"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/main.py\", line 318 in pytest_cmdline_main\n  File \"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_callers.py\", line 77 in _multicall\n  File \"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_manager.py\", line 115 in _hookexec\n  File \"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_hooks.py\", line 493 in __call__\n  File \"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/config/__init__.py\", line 169 in main\n  File \"tests/ci/azureml_tests/run_groupwise_pytest.py\", line 68 in <module>\n  File \"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/runpy.py\", line 87 in _run_code\n  File \"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/runpy.py\", line 97 in _run_module_code\n  File \"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/runpy.py\", line 265 in run_path\n  File \"<string>\", line 193 in main\n  File \"<string>\", line 197 in <module>\n",
        "messageParameters": ***,
        "details": []
    ***,
    "time": "0001-01-01T00:00:00.000Z",
    "componentName": "CommonRuntime"
***
	InnerException None
	ErrorResponse 
***
    "error": ***
        "message": "Activity Failed:\n***\n    \"error\": ***\n        \"code\": \"UserError\",\n        \"message\": \"Execution failed. User process '/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/bin/python' terminated by signal 4. Please check log file 'user_logs/std_log.txt' for error details. Error:   File \\\"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_callers.py\\\", line 77 in _multicall\\n  File \\\"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_manager.py\\\", line 115 in _hookexec\\n  File \\\"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_hooks.py\\\", line 493 in __call__\\n  File \\\"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/main.py\\\", line 350 in pytest_runtestloop\\n  File \\\"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_callers.py\\\", line 77 in _multicall\\n  File \\\"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_manager.py\\\", line 115 in _hookexec\\n  File \\\"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_hooks.py\\\", line 493 in __call__\\n  File \\\"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/main.py\\\", line 325 in _main\\n  File \\\"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/main.py\\\", line 271 in wrap_session\\n  File \\\"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/main.py\\\", line 318 in pytest_cmdline_main\\n  File \\\"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_callers.py\\\", line 77 in _multicall\\n  File \\\"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_manager.py\\\", line 115 in _hookexec\\n  File \\\"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_hooks.py\\\", line 493 in __call__\\n  File \\\"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/config/__init__.py\\\", line 169 in main\\n  File \\\"tests/ci/azureml_tests/run_groupwise_pytest.py\\\", line 68 in <module>\\n  File \\\"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/runpy.py\\\", line 87 in _run_code\\n  File \\\"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/runpy.py\\\", line 97 in _run_module_code\\n  File \\\"/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/runpy.py\\\", line 265 in run_path\\n  File \\\"<string>\\\", line 193 in main\\n  File \\\"<string>\\\", line 197 in <module>\\n\",\n        \"messageParameters\": ***,\n        \"details\": []\n    ***,\n    \"time\": \"0001-01-01T00:00:00.000Z\",\n    \"componentName\": \"CommonRuntime\"\n***"
    ***
***
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/threading.py", line 558 in wait
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/threading.py", line 1252 in run
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/threading.py", line 932 in _bootstrap_inner
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/threading.py", line 890 in _bootstrap

Thread 0x000014663ba35700 (most recent call first):
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/threading.py", line 306 in wait
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/threading.py", line 558 in wait
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/tqdm/_monitor.py", line 60 in run
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/threading.py", line 932 in _bootstrap_inner
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/threading.py", line 890 in _bootstrap

Current thread 0x000014667c91a280 (most recent call first):
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/lightfm/lightfm.py", line 684 in _run_epoch
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/lightfm/lightfm.py", line 655 in fit_partial
  File "/mnt/azureml/cr/j/136f15e8d32d4bbc8f0c09009929d765/exe/wd/recommenders/models/lightfm/lightfm_utils.py", line 85 in track_model_metrics
  File "/mnt/azureml/cr/j/136f15e8d32d4bbc8f0c09009929d765/exe/wd/tests/unit/recommenders/models/test_lightfm_utils.py", line 101 in fitting
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/fixtures.py", line 902 in call_fixture_func
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/fixtures.py", line 1123 in pytest_fixture_setup
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_callers.py", line 77 in _multicall
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_manager.py", line 115 in _hookexec
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_hooks.py", line 493 in __call__
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/fixtures.py", line 1069 in execute
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/fixtures.py", line 693 in _compute_fixture_value
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/fixtures.py", line 607 in _get_active_fixturedef
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/fixtures.py", line 585 in getfixturevalue
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/fixtures.py", line 566 in _fillfixtures
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/python.py", line 1795 in setup
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/runner.py", line 494 in setup
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/runner.py", line 157 in pytest_runtest_setup
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_callers.py", line 77 in _multicall
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_manager.py", line 115 in _hookexec
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_hooks.py", line 493 in __call__
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/runner.py", line 262 in <lambda>
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/runner.py", line 341 in from_call
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/runner.py", line 261 in call_runtest_hook
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/runner.py", line 222 in call_and_report
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/runner.py", line 127 in runtestprotocol
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/runner.py", line 114 in pytest_runtest_protocol
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_callers.py", line 77 in _multicall
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_manager.py", line 115 in _hookexec
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_hooks.py", line 493 in __call__
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/main.py", line 350 in pytest_runtestloop
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_callers.py", line 77 in _multicall
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_manager.py", line 115 in _hookexec
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_hooks.py", line 493 in __call__
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/main.py", line 325 in _main
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/main.py", line 271 in wrap_session
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/main.py", line 318 in pytest_cmdline_main
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_callers.py", line 77 in _multicall
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_manager.py", line 115 in _hookexec
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/pluggy/_hooks.py", line 493 in __call__
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/site-packages/_pytest/config/__init__.py", line 169 in main
  File "tests/ci/azureml_tests/run_groupwise_pytest.py", line 68 in <module>
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/runpy.py", line 87 in _run_code
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/runpy.py", line 97 in _run_module_code
  File "/azureml-envs/azureml_e834b9ec89f7665e8939261e88cc479d/lib/python3.8/runpy.py", line 265 in run_path
  File "<string>", line 193 in main
  File "<string>", line 197 in <module>

Execution Summary
=================
RunId: unit_tests_group_cpu_001_1694982723_22441a79
Web View: https://ml.azure.com/runs/unit_tests_group_cpu_001_1694982723_22441a79?wsid=/subscriptions/***/resourcegroups/recommenders_project_resources/workspaces/azureml-test-workspace&tid=***

Warnings:
AzureMLCompute job failed
ExecutionFailed: [REDACTED]
	exit_codes: -2
	Appinsights Reachable: Some(true)

Error: Process completed with exit code 1.

Signed-off-by: miguelgfierro <[email protected]>

tests/unit/recommenders/utils/test_gpu_utils.py

setup.py

anargyri · 2023-09-19T17:04:37Z

tests/regression/test_compatibility_tf.py

+
+
+@pytest.mark.gpu
+def test_compatibility_tf():


Maybe enclose in try - catch and raise AssertionError ?

Refactor data validation tests

5f18cae

Signed-off-by: miguelgfierro <[email protected]>

loomlike approved these changes Sep 12, 2023

View reviewed changes

miguelgfierro added 2 commits September 15, 2023 13:52

Merge branch 'staging' into miguel/new_test_categories

cd6cc35

Changed test_dataset to test_download_utils FYI @looklike

5457f50

Signed-off-by: miguelgfierro <[email protected]>

miguelgfierro mentioned this pull request Sep 15, 2023

[FEATURE] better name for test_dataset.py #1991

Closed

miguelgfierro and others added 9 commits September 15, 2023 14:12

Performance tests

1fc7b85

Signed-off-by: miguelgfierro <[email protected]>

Security tests

2799676

Signed-off-by: miguelgfierro <[email protected]>

Security tests

8b61faf

Signed-off-by: miguelgfierro <[email protected]>

Regression tests

bb66531

Signed-off-by: miguelgfierro <[email protected]>

Regression tests

7bd6bd7

Signed-off-by: miguelgfierro <[email protected]>

Criteo responsible AI

e483b62

Signed-off-by: miguelgfierro <[email protected]>

Movielens responsible AI

f985b66

Signed-off-by: miguelgfierro <[email protected]>

🐛

d6e5dbd

Signed-off-by: miguelgfierro <[email protected]>

Forgot s

0ddd3f9

miguelgfierro added 14 commits September 16, 2023 09:09

criteo

46c6ffc

Signed-off-by: miguelgfierro <[email protected]>

criteo

5d3b1ab

Signed-off-by: miguelgfierro <[email protected]>

mind

79de76f

Signed-off-by: miguelgfierro <[email protected]>

movielens

abaa152

Signed-off-by: miguelgfierro <[email protected]>

movielens WIP

da9dffc

Signed-off-by: miguelgfierro <[email protected]>

movielens

51bca98

Signed-off-by: miguelgfierro <[email protected]>

🐛

a42cea0

Signed-off-by: miguelgfierro <[email protected]>

integration to functional

c243389

Signed-off-by: miguelgfierro <[email protected]>

integration to functional

6b01105

Signed-off-by: miguelgfierro <[email protected]>

functional CPU

64929e7

Signed-off-by: miguelgfierro <[email protected]>

functional GPU and Spark

106aee1

Signed-off-by: miguelgfierro <[email protected]>

Integration

1eb3313

Signed-off-by: miguelgfierro <[email protected]>

Reviewing smoke

b9b2a21

Signed-off-by: miguelgfierro <[email protected]>

Reviewing smoke

1a8ab4a

Signed-off-by: miguelgfierro <[email protected]>

miguelgfierro requested review from gramhagen, anargyri, wutaomsft and SimonYansenZhao as code owners September 16, 2023 17:23

miguelgfierro added 17 commits September 16, 2023 22:43

unit tests notebooks

3fc4e0d

Signed-off-by: miguelgfierro <[email protected]>

unit tests dataset

61868d2

Signed-off-by: miguelgfierro <[email protected]>

unit python evaluation

dfa0c55

Signed-off-by: miguelgfierro <[email protected]>

unit pyspark evaluation

9498642

Signed-off-by: miguelgfierro <[email protected]>

Added en extra s

0eea4d8

Signed-off-by: miguelgfierro <[email protected]>

unit models WIP

224e15b

Signed-off-by: miguelgfierro <[email protected]>

unit models WIP

34665b0

Signed-off-by: miguelgfierro <[email protected]>

unit models

c26a6a3

Signed-off-by: miguelgfierro <[email protected]>

unit tuning

66e6dca

Signed-off-by: miguelgfierro <[email protected]>

unit utils

3cdb4d3

Signed-off-by: miguelgfierro <[email protected]>

📝

0fbbec1

Signed-off-by: miguelgfierro <[email protected]>

🐛

c40ffce

Signed-off-by: miguelgfierro <[email protected]>

🐛

de11824

Signed-off-by: miguelgfierro <[email protected]>

🐛

e26f4ff

Signed-off-by: miguelgfierro <[email protected]>

Update readme tests

fdee579

Signed-off-by: miguelgfierro <[email protected]>

License file changed so the maybe download tests had to be updated

54b171b

Signed-off-by: miguelgfierro <[email protected]>

📝

1c1e1e4

Signed-off-by: miguelgfierro <[email protected]>

ignoring one of the lightfm for a weird error

0d17767

Signed-off-by: miguelgfierro <[email protected]>

anargyri reviewed Sep 18, 2023

View reviewed changes

tests/unit/recommenders/utils/test_gpu_utils.py Show resolved Hide resolved

anargyri reviewed Sep 18, 2023

View reviewed changes

setup.py Show resolved Hide resolved

anargyri reviewed Sep 19, 2023

View reviewed changes

anargyri approved these changes Sep 19, 2023

View reviewed changes

miguelgfierro merged commit 399f1c5 into staging Sep 19, 2023
20 checks passed

miguelgfierro deleted the miguel/new_test_categories branch September 19, 2023 17:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor tests into new categories reviewed by Eric Gamma #1989

Refactor tests into new categories reviewed by Eric Gamma #1989

miguelgfierro commented Sep 7, 2023 •

edited

loomlike left a comment

loomlike Sep 12, 2023

miguelgfierro Sep 15, 2023

miguelgfierro commented Sep 12, 2023

miguelgfierro commented Sep 16, 2023 •

edited

miguelgfierro commented Sep 16, 2023

miguelgfierro commented Sep 17, 2023

anargyri Sep 19, 2023



		@pytest.mark.gpu
		def test_compatibility_tf():

Refactor tests into new categories reviewed by Eric Gamma #1989

Refactor tests into new categories reviewed by Eric Gamma #1989

Conversation

miguelgfierro commented Sep 7, 2023 • edited

Description

Related Issues

References

Checklist:

loomlike left a comment

Choose a reason for hiding this comment

loomlike Sep 12, 2023

Choose a reason for hiding this comment

miguelgfierro Sep 15, 2023

Choose a reason for hiding this comment

miguelgfierro commented Sep 12, 2023

miguelgfierro commented Sep 16, 2023 • edited

miguelgfierro commented Sep 16, 2023

miguelgfierro commented Sep 17, 2023

anargyri Sep 19, 2023

Choose a reason for hiding this comment

miguelgfierro commented Sep 7, 2023 •

edited

miguelgfierro commented Sep 16, 2023 •

edited