Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit scipy <1.11.0 until #1954 is fixed #1971

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Conversation

miguelgfierro
Copy link
Collaborator

Description

On Aug 18, a new version of scipy was released and broke our tests again. We need to fix #1954, otherwise, all new versions of scipy won't work.

This PR restrict the dep to <1.11.0 until we fix that issue

Related Issues

See https://github.com/recommenders-team/recommenders/actions/runs/5907706378/job/16026070536#step:16:3608

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

wutaomsft and others added 4 commits April 22, 2023 13:19
Staging to main: fix tests and update documentation
Staging to main: Fix latest errors and rerun the notebooks with Python 3.9
@miguelgfierro
Copy link
Collaborator Author

@loomlike this one is the solution to the other PRs that are failing, until this one is not merged, we can´t do much

@loomlike
Copy link
Collaborator

Does #1954 require a big changes or can it be done quickly?

@miguelgfierro
Copy link
Collaborator Author

miguelgfierro commented Aug 28, 2023

Does #1954 require a big changes or can it be done quickly?

It might be quick.

But in any case, until this PR is merged, all the tests will fail. @loomlike Can we merge this one, and then work on the SAR issue?

@loomlike
Copy link
Collaborator

I created #1980 so that we can track to revert this later.

@miguelgfierro miguelgfierro merged commit 6eb15ab into staging Aug 29, 2023
29 checks passed
@miguelgfierro miguelgfierro deleted the miguelgfierro-patch-1 branch August 29, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants