Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The changes has been made to simplify the arguments required for the evaluation of @k metrics. It was found that
col_rating
column wasn't used by the these methods, hence the function signature could be simplified for better user experience.Pytest Results
>>>pytest tests/unit/recommenders/evaluation/test_python_evaluation.py platform darwin -- Python 3.8.14, pytest-7.1.3, pluggy-1.0.0 rootdir: /Users/asoni9/Desktop/recommenders plugins: hypothesis-6.56.2, mock-3.10.0, rerunfailures-10.2, cov-4.0.0 collected 30 items tests/unit/recommenders/evaluation/test_python_evaluation.py .............................. ==== 30 passed, 8 warnings in 0.84s ====
Related Issues
#1737
References
Not Applicable
Checklist:
staging branch
and not tomain branch
.