Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hlgroups/NormalFloat/FloatBorder: Consider using the color sumiink1 instead of bg_dark #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CleoMenezesJr
Copy link

Currently, LSP diagnostics, using a floating style in my case, shows a background that does not match the original background. This occurs with other apps that use floating styles such as searchbox.nvim as shown in the issue #72.

  • LSP diagnostic

    • Before
      image
    • After
      image
  • SearchBox.nvim

    • Before
      image
    • After
      image

@rebelot
Copy link
Owner

rebelot commented Sep 7, 2022

Hlgroups should use theme color names (i.e. bg), not palette colors.

This was a tough decision, but I preferred floating windows to have a darker background. It arguably looks bad with common borders tho.

Personally I use box characters that are drawn on the outer margin of the character grid. I'll give it a try and might reconsider tho.

@vicrdguez
Copy link

This can be solved using the following configs, without changing the code:

	vim.api.nvim_set_hl(0, "NormalFloat", { bg = "#1F1F28", blend = 0})
	vim.api.nvim_set_hl(0, "FloatBorder", { bg = "#1F1F28"})
	vim.api.nvim_set_hl(0, "FloatTitle", { bg = "none"})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants