RNET-1145, RNET-1143: Fix reading schema from native #3601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9181337499Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
papafe
approved these changes
May 21, 2024
Realm/Realm/Realm.cs
Outdated
| { | ||
| ThrowIfDisposed(); | ||
| Argument.Ensure(obj.IsManaged, "Only managed objects can be used in FindExisting", nameof(obj)); | ||
| var metadata = Metadata[typeof(T).GetMappedOrOriginalName()]; |
There was a problem hiding this comment.
Small optimization, but maybe we can move this inside the if?
nirinchev
added a commit
that referenced
this pull request
May 22, 2024
* main: RNET-1134: Add obfuscation attribute on generated RealmSchema (#3594) Revert "Hide collections in mixed from public API" (#3606) Update to Core 14.7.0 (#3605) RNET-1145, RNET-1143: Fix reading schema from native (#3601) # Conflicts: # .github/templates/test-weaver.yml # .github/workflows/test-weaver.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes how we're reading Realm schema from native. It seems that for a few string properties, the default value in Core is empty string, whereas in .NET those are nullable, so our checks for
object_type == nullwere failing and we were trying to lookup metadata for primitive properties.Additionally, this adds
Migration.FindInNewRealmsince I saw we're missing that, which made the test easier to write.Fixes #3600
Fixes #3597
TODO