Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RNET-1126: Fix flaky tests on CI #3595

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

RNET-1126: Fix flaky tests on CI #3595

wants to merge 5 commits into from

Conversation

papafe
Copy link
Contributor

@papafe papafe commented May 3, 2024

Fixes #3560

@cla-bot cla-bot bot added the cla: yes label May 3, 2024
@papafe papafe added the no-changelog Used to skip the changelog check label May 3, 2024
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented May 3, 2024 •
edited

Pull Request Test Coverage Report for Build 8998094213

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.137%
Totals Coverage Status
Change from base Build 8937828998: 0.0%
Covered Lines: 6724
Relevant Lines: 8241
💛 - Coveralls

@papafe
Copy link
Contributor Author

papafe commented May 8, 2024

The cause of the flakyness seems to be due to some various timing issues:

  • Reusing the same object for different tests led to realm exceptions when adding an object with the same primary key
  • When objects are added directly to Atlas, the synchronization of objects does not respect the boundaries of changesets, that can be broken down in smaller pieces (especially when working with links). This means that sometimes the elements of collections of links are not added all together, and this did not work with our expectations. This is the reason I've added much more WaitForConditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@papafe papafe

Labels
cla: yes no-changelog Used to skip the changelog check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix flaky static queries tests
1 participant
@papafe