LINQ Provider Rewrite #2518
LINQ Provider Rewrite #2518
Conversation
joakim-olsson
requested review from
fealebenpae,
DominicFrei,
nirinchev and
LaPeste
joakim-olsson
force-pushed
the
jo/rewrite
branch
from
ce0cad0
to
4a261fe
Compare
…orted sorting methods
| { | ||
| Visit(node.Arguments[0]); | ||
| var whereClause = new WhereClauseVisitor(_metadata); | ||
| var lambda = (LambdaExpression)StripQuotes(node.Arguments[1]); |
There was a problem hiding this comment.
Take a look at this comment
|
|
||
| namespace Realms | ||
| { | ||
| internal class SortClauseVisitor |
There was a problem hiding this comment.
Make a base class, something called "ClauseVisitor", that also has the strip method
| throw new NotSupportedException($"The operator '{binaryExpression.NodeType}' is not supported"); | ||
| } | ||
|
|
||
| if (binaryExpression.Left is MemberExpression binaryLeftMemberExpression) |
There was a problem hiding this comment.
You have a lot of repeated code here, try to avoid this. There is no difference between left and right here
| { | ||
| if (node.Expression != null && node.Expression.NodeType == ExpressionType.Parameter) | ||
| { | ||
| ComparisonNode comparisonNode = new EqualityNode(); |
There was a problem hiding this comment.
boolean statements with no equality sign (e.g .Where(p => !p.IsInteresting))
|
|
||
| private static string GetKind(object valueType) | ||
| { | ||
| if (valueType == typeof(float)) |
There was a problem hiding this comment.
Can we do this with a switch statement? Also, does valueType need to be object? Can we be more specific with the type?
There was a problem hiding this comment.
Did some research on this and it does not seem like there is a good way to do this, we can discuss this later
# Conflicts: # wrappers/realm-core
|
This is still a draft, but I've cleaned it out a little, so it should be readable enough. |
Description
I'm experimenting with ways to rewrite the way the LINQ provider works to a more object-oriented structure. This is just a rough sketch so this is not planned to be merged and might not even be close to the end product.
The idea is to have it as objects so that it can be easily transferred to a JSON structure if that is the case. E.g a query like:
var query = _realm.All<Person>().Where(p => p.Score == 5 && p.FirstName == "Test" && p.LastName == "Testersson");should give the ability to create a JSON structure like:
{ "WhereClause": [ { "property": "Score", "value": 5, "op": "eq" }, { "property": "FirstName", "value": "Test", "op": "eq" }, { "property": "LastName", "value": "Testersson", "op": "eq" } ] }