Add vendor support to Android blueprints #7614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leemaguire
force-pushed
the
lm/android-bp
branch
from
73bd7be
to
cf99a3d
Compare
Pull Request Test Coverage Report for Build lee.maguire_78Details
💛 - Coveralls |
leemaguire
added
the
no-jira-ticket
fealebenpae
approved these changes
May 21, 2024
Merged
dg0yt
reviewed
May 30, 2024
Comment on lines
+36
to
+40
| #if REALM_ANDROID && !defined(REALM_AOSP_VENDOR) | ||
| #define HAS_ANDROID_ALOOPER | ||
| #endif | ||
|
|
||
| #if HAS_ANDROID_ALOOPER |
There was a problem hiding this comment.
This expands either to
#if
or
#if HAS_ANDROID_ALOOPER
causing
/mnt/vcpkg-ci/b/realm-core/src/14.8.0-91fbc84ff4.clean/src/realm/object-store/util/scheduler.cpp:40:24: error: expected value in expression
#if HAS_ANDROID_ALOOPER
There was a problem hiding this comment.
Hi @dg0yt the latest master contains a fix for this where it becomes #if defined(HAS_ANDROID_ALOOPER)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds vendor support for Android Blueprints and is a prerequisite for RCPP-47
☑️ ToDos