added resolve_all to container #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 0.1
v0.6 docs fixes
Tishka17
reviewed
Mar 27, 2024
| @overload | ||
| def resolve_all(self, components: None = None) -> None: ... | ||
| @overload | ||
| def resolve_all(self, components: Literal[True]) -> None: ... |
There was a problem hiding this comment.
What's the purpose of that?
Tishka17
reviewed
Mar 27, 2024
| @overload | ||
| def resolve_all(self, components: Iterable[Component]) -> None: ... | ||
|
|
||
| def resolve_all(self, components: Any = None) -> None: |
There was a problem hiding this comment.
Do we really need specify components? What's the use case?
Tishka17
reviewed
Mar 27, 2024
| """ | ||
| if not components: | ||
|
|
||
| def component_check(k: DependencyKey) -> bool: |
There was a problem hiding this comment.
Get rid of nested functions
Tishka17
reviewed
Mar 27, 2024
| return k.component in components | ||
|
|
||
| for key in filter(component_check, self.registry.factories): | ||
| with suppress(NoContextValueError): |
Tishka17
reviewed
Mar 27, 2024
| @overload | ||
| def resolve_all(self, components: Iterable[Component]) -> None: ... | ||
|
|
||
| def resolve_all(self, components: Any = None) -> None: |
There was a problem hiding this comment.
Don't we need to call parent container method as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.