Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update reproducible builds guide #10939

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

duboism
Copy link

@duboism duboism commented Dec 1, 2023

As discussed in #10924, we propose to update the reproducible builds guide (docs/user/guides/reproducible-builds.rst). The goals are:

  • update instruction for config v2 file
  • clarify that versions in the guide are just example and not recommended
  • don't use the buggy sphinx=5.3.0 in the example

📚 Documentation previews 📚

@duboism duboism marked this pull request as ready for review December 5, 2023 21:48
@duboism duboism requested a review from a team as a code owner December 5, 2023 21:48
@duboism
Copy link
Author

duboism commented Dec 5, 2023

I finished the main proposed modifications.

However, I don't understand the "✅ Good:" badge in Pin your transitive dependencies. Any thoughts ?

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think it's good and ready to merge after some small changes 👍🏼

docs/user/guides/reproducible-builds.rst Outdated Show resolved Hide resolved
docs/user/guides/reproducible-builds.rst Show resolved Hide resolved
docs/user/guides/reproducible-builds.rst Outdated Show resolved Hide resolved
docs/user/guides/reproducible-builds.rst Show resolved Hide resolved
@duboism
Copy link
Author

duboism commented Jan 10, 2024

Sorry for the delay. I commented on the various points you raised and modified the code.

@duboism
Copy link
Author

duboism commented Jan 21, 2024

Any news ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants