Include previous exceptions when reporting unhandled promise rejections #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset makes sure we include any previous exceptions when reporting unhandled promise rejections. In particular, instead of reporting a custom message, we now use PHP's default
Throwable::__toString()logic which includes the exception type, its message, stack trace and any previous exceptions by default (https://3v4l.org/lBRM1).Including any previous exceptions makes sense as a default behavior to be in line with PHP's default exception output and to make it easier to track down any unhandled promise rejections. Like previously, this behavior only triggers for any unhandled promise rejections and can be customized by using a global rejection handler as explained in https://github.com/reactphp/promise#set_rejection_handler.
Builds on top of #248 and #249