[SHELL32] SHBrowseForFolder: Refactor brsfolder.c #6903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katahiromz
added
refactoring
katahiromz
changed the title
katahiromz
changed the title
|
Double checked. Let's go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
dll/win32/shell32/wine/brsfolder.c. This file is too hard to read. Nobody reads.And WineHQ doesn't show no progress recently in this file. OUT OF DATE!
JIRA issue: CORE-17340
Proposed changes
SendMessageWcode by usingTreeView_...macros.BrsFolder_GetDataFromItemhelper function and use it.TODO