[REGEDIT] Implement "Add to favorites" feature #6890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binarymaster
changed the title
HBelusca
reviewed
May 15, 2024
| return EndDialog(hWnd, err); | ||
| } | ||
| case IDCANCEL: | ||
| return EndDialog(hWnd, ERROR_CANCELLED); |
There was a problem hiding this comment.
Not really useful to return a Win32 error code there, and in the IDOK case above (caller doesn't use that code at all).
There was a problem hiding this comment.
I know it is not super useful but it costs me nothing so why not?
There was a problem hiding this comment.
This is in regards to the fact the returned result of the DialogBoxW() call below won't really be used.
There was a problem hiding this comment.
I know the caller does not care at the moment but I have already calculated the error value, it costs me nothing to return it.
HBelusca
reviewed
May 15, 2024
HBelusca
requested review from
binarymaster,
katahiromz,
cbialorucki and
DarkFire01
katahiromz
reviewed
May 16, 2024
katahiromz
reviewed
May 16, 2024
katahiromz
reviewed
May 16, 2024
katahiromz
reviewed
May 16, 2024
katahiromz
approved these changes
May 16, 2024
katahiromz
reviewed
May 16, 2024
cbialorucki
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to go to a favorite and the dialog was already there, just needed to fill in the blanks.