Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Move deprecated APIs in sidebar #6759

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kassens
Copy link
Collaborator

@kassens kassens commented Apr 16, 2024

This is a proposal how we can retain pages for deprecated APIs while maintaining an "evergreen" page that avoids creating versioned copies.

This adds a new navigation entry for the deprecated React DOM APIs where they can remain. I greyed out the text to de-emphasize the navigation entry.

The moved doc pages retain their original URL even when they're under a different entry now. We could also consider making the old URLs a redirect to a /deprecated/ path.

Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 4:16pm

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 79.9 KB (🟡 +30 B) 183.81 KB
/500 79.9 KB (🟡 +30 B) 183.8 KB
/[[...markdownPath]] 81.7 KB (🟡 +47 B) 185.6 KB
/errors 80.08 KB (🟡 +30 B) 183.99 KB
/errors/[errorCode] 80.06 KB (🟡 +30 B) 183.96 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants