New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix word component(s) capitalization #6717
base: main
Are you sure you want to change the base?
fix: Fix word component(s) capitalization #6717
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @anthonylaflamme! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Five Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
just signed the CLA |
there is two instances of the word "subcomponent" should these be sub Components or we leave them as is ? |
I also wonder about places where we talk about HTML Element but refer to them as component ex: " The built-in browser This might be out of scope for this PR but should these be Element instead of Component ? |
@anthonylaflamme thanks for taking a stab! Can you revert the homepage, /blog and /community changes? Let's just keep those as-is. Can you also revert the capitalization for things that are not referring to the React Component concept directly? I update #6713 with a style guide to try and make it clearer when to capitalize. Some example from this PR that should not be capitalized:
Admittedly this is tricky, my mental model for this is "would it make sense to link to the docs for components here" or "could this be replaced with 'React Component'"? |
Thank you for making this more precise. I will continue to update them as I read through the context of some of them I should be able to pull this in a timely manner. |
@@ -561,11 +561,11 @@ label { | |||
|
|||
</Sandpack> | |||
|
|||
Here, you switch between _different_ component types at the same position. Initially, the first child of the `<div>` contained a `Counter`. But when you swapped in a `p`, React removed the `Counter` from the UI tree and destroyed its state. | |||
Here, you switch between _different_ Component types at the same position. Initially, the first child of the `<div>` contained a `Counter`. But when you swapped in a `p`, React removed the `Counter` from the UI tree and destroyed its state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one feels tricky @rickhanlonii do you think this should be Component or component ? Since we are talking about the react context here but also referencing one React Component (Counter) but also built ins (<p>
) ?
Do I have to do this with all the file's out there, Tell me and assign this issue I will do it! |
This pr fixes the word component(s) capitalization for issue #6713