Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalized State #6714

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

haroon6268
Copy link

Hello, today was my first time doing a pull request so please let me know if I am doing anything wrong. I capitalized state in the adding-interactivity.md file.

@facebook-github-bot
Copy link
Collaborator

Hi @haroon6268!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-dev ✅ Ready (Inspect) Visit Preview Mar 27, 2024 4:21am

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@pwbriggs
Copy link

pwbriggs commented Apr 4, 2024

Hey there @haroon6268! 👋

#6713 (comment) has been updated with a brief style guide for what instances of the terms should be capitalized, and what should remain lowercase. Could you please:

  1. Read through Capitalize React concepts in docs #6713 (comment) again (it's been edited a lot in the past few days)
  2. Update your pull request (just push the commit to the capitalized-state branch in your fork and GitHub with automatically update it here).

I think there's a few instances in your PR that should stay lowercase, for example

Instead, when you want to update an object and array, you need to create a new one (or make a copy of an existing one), and then update the State to use that copy.

Not an expert on this, though. Maybe @rickhanlonii can confirm?

In any case, thanks for the contribution! You're on the way to a great PR. I hope this was helpful. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants