New prop (showCaret) proposal for the tooltip component. #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ran locally
|
|
ok fixed the |
keyurpatel
force-pushed
the
keyurpatel-tooltip-caret
branch
from
f977ca0
to
7e8b582
Compare
|
@rubenmoya I have addressed the conflict can you please take a look for this cool feature addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for putting together this brilliant component set. I would like to propose a new prop on Tooltip component -
showCaret. It's a boolean prop which will show caret along with tooltip for better UI and ease of use to anyone.Preview