Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropdown entry selection issue #1725

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

rndevfx
Copy link
Contributor

@rndevfx rndevfx commented Oct 26, 2017

Currently a user have to click twice on an entry within the dropdown
list to close it. This happens because the li click event will call
'handleSelect' and the default behavior calls 'handleDocumentClick'.
This is wrong when the user clicks on an entry (and not outside of
the dropdown) so now the 'handleSelect' prevents the default behaviour.

Currently a user have to click twice on an entry within the dropdown
list to close it. This happens because the li click event will call
'handleSelect' and the default behavior calls 'handleDocumentClick'.
This is wrong when the user clicks on an entry (and not outside of
the dropdown) so now the 'handleSelect' prevents the default behaviour.
@rubenmoya
Copy link
Collaborator

Can you tell me the steps to reproduce that problem? I'm trying the dropdown in the playground and I'm not able to reproduce it :(

@rndevfx
Copy link
Contributor Author

rndevfx commented Nov 17, 2017

Can you try it with the dev branch? On the website it works/worked fine but when you build the docs on your machine with latest dev (currently broken on my machine) you maybe can reproduce it :)

EDIT: Broken docs at #1733

@vitalif
Copy link

vitalif commented Feb 1, 2018

+1 it seems there's no such problem

@louisremi
Copy link

I've had the same problem for quite some time now. I'm using react-toolbox with Preact and I assumed it was an incompatibility with that lib (see #1617 as well). I now assume the problem lies somewhere else, but putting e.preventDefault in my onChange handler did the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants