fix: [Drawer] fix iOS wrong detected frame dimensions #11632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It seems that under certain scenarios on iOS, the useSafeAreaFrame hook is returning incorrect dimensions. The issue may lie in the native implementation of methods responsible for layout (
layoutSubviews
,layoutIfNeeded
, etc). However, we only require theheight
andwidth
of the main window, as the Drawer is hidden behind the root View and we do not need the x and y coordinates of the top frame as SafeAreaRect
provides.Test plan
Open Drawer
Open iOS Modal
dimensions values are correct and event is broadcasting properly
Rotate screen landscape
Rotate screen portrait
dimensions values broken and are no longer broadcast
Close modal
The change must pass lint, typescript and tests.
Simulator.Screen.Recording.-.iPhone.15.-.2023-10-08.at.09.17.57.mp4
Untitled.mov
RN info
Navigator snippet to reproduce