Fixed onModalHide being called early #733
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The
onModalHide
is being called too early (i.e. before actually hiding the modal) and if we try to focus an element on that callback it will fail due to RN focus trap.Unfortunately there is no easy way to know when the modal has been hidden (RN does not have
onHide
prop). But I found that we can fix this be delaying the callback by 2 cycles, first one to ensure that the modal content has been unmounted and the second to ensure that the focus trap is no longer active (after refocusing the element that triggered opening the modal).Test Plan
Consider the example stated above where we try to focus an element
onModalHide
callback.Kooha-2023-02-12-13-20-44.mp4
Kooha-2023-02-12-13-22-42.mp4