Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SearchBar): fixed iOS search bar icons issue #3865

Merged

Conversation

JaweedVenturedive
Copy link
Contributor

Motivation

On Search Bar when passing "ios" to platform prop the icon shows question mark '?' symbol, which shows icon is not available and throws warning. Fixed this issue by modifying the SearchBar.ios.tsx by providing proper and available props for name property when displaying icons.

Fixes #3837

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Existing unit tests pass locally with my changes

Additional context

Before Fix

Screenshot 2023-11-30 at 4 23 04 PM

After Fix

Screenshot 2023-11-30 at 4 22 38 PM

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d785b0d) 79.69% compared to head (9925c4e) 79.69%.
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3865   +/-   ##
=======================================
  Coverage   79.69%   79.69%           
=======================================
  Files          87       87           
  Lines        1842     1842           
  Branches      818      818           
=======================================
  Hits         1468     1468           
  Misses        369      369           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khushal87
Copy link
Member

khushal87 commented Dec 27, 2023

Hey @JaweedVenturedive what's the vector icon package version for which you are facing the issue? I was not able to reproduce the issue on my iOS device.

@JaweedVenturedive
Copy link
Contributor Author

Hey @JaweedVenturedive what's the vector icon package version for which you are facing the issue? I was not able to reproduce the issue on my iOS device.

Hello, @khushal87 I can re-produce the issue on vector icon package version 10.0.2.

@khushal87
Copy link
Member

Screenshot 2023-12-27 at 5 17 21 PM Using the same version and not been able to reproduce it on our sample app

@JaweedVenturedive
Copy link
Contributor Author

Screenshot 2023-12-27 at 5 17 21 PM Using the same version and not been able to reproduce it on our sample app

@khushal87 Let me re-check again.

@JaweedVenturedive
Copy link
Contributor Author

@khushal87 I can re-produce the issue on both android and iOS devices.
Screenshot 2023-12-27 at 5 09 10 PM
Screenshot 2023-12-27 at 5 03 05 PM

@khushal87
Copy link
Member

My assumption is something is wrong with my setup. Regardless from the issue comments I interpret that it is a genuine issue. Therefore merging it. Thanks for your contributions. 😄

@khushal87 khushal87 merged commit 43d1587 into react-native-elements:next Dec 27, 2023
9 checks passed
@JaweedVenturedive
Copy link
Contributor Author

@khushal87 Thank you so much for your response ♥️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SearchBar - iOS icon error
3 participants