Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SocialIcon): handle button prop correctly #3860

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

darkbasic
Copy link
Contributor

Motivation

image

The SocialIcon component does not handle the button prop correctly, this PR fixes it:

<SocialIcon type="facebook" button title="Facebook" />
<SocialIcon type="instagram" title="Instagram" />

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app
  • Checked in production app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c87b7ec) 79.70% compared to head (d3e77a8) 79.71%.
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3860      +/-   ##
==========================================
+ Coverage   79.70%   79.71%   +0.01%     
==========================================
  Files          87       87              
  Lines        1843     1844       +1     
  Branches      819      821       +2     
==========================================
+ Hits         1469     1470       +1     
  Misses        369      369              
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arpitBhalla arpitBhalla merged commit cec04af into react-native-elements:next Jan 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants