Fixed looping issue Android #245
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed behavior where setting the looping flag for a specific Player instance would set this behavior for the entire module (for all Player instances)
|
Why so important pull request waiting 2+ month ? :) |
|
Yep! I've also meet this bug. Thank you for fixing it! |
progsmile
added a commit
to progsmile/react-native-audio-toolkit
that referenced
this pull request
May 9, 2021
|
I'm also facing this issue. Any reason for not having it merged yet? |
cristianocasm
pushed a commit
to tophatter/react-native-audio-toolkit
that referenced
this pull request
Aug 19, 2021
This was referenced Sep 8, 2021
Merged
|
Hello there 👋 I made a fork of this project and create a npm package with the #245 and #224 fixes. Hope it could help ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed behavior where setting the looping flag for a specific Player instance would set this behavior for the entire module (for all Player instances)