Migrate useWindowSize tests to @testing-library/react
#1377
Conversation
|
@JoeDuncko @ArttuOll requesting some help with this one. |
xobotyi
changed the title
@testing-library/react
xobotyi
changed the title
@testing-library/reactuseWindowSize tests to @testing-library/react
|
|
||
| triggerResize('width', 200); | ||
| triggerResize('height', 200); |
There was a problem hiding this comment.
@xobotyi Why did we changed it to hieght from width?
There was a problem hiding this comment.
I have no idea, to be fair =) it is not intended
There is still an issue with harness - have to rewrite it
|
@xobotyi Wanted to contribute in this migration.
|
|
Main issue is that i dont know how to properly migrate to react 18. ideally we have to migrate first to So it seems that ill have to swrite harnesses for react 17, then migrate all tests to |
As
@testing-library/react-hookslibrary is abandoned and forces users to switch to@testing-library/reactsimple switch of react versions implies adapting most of tests.The library change is not a drop-in threfore requires manual rewriting all tests accroding to [migration guide]
As
@testing-library/reactdo not offer a solution for SSR hooks testing - i made an ssr harness which i'm planning to extract to separte package lately when all tests moved and harness will prove to be viable.