fix: correct type of error field in getFieldState return object
#11831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
Hey there! It seems that your change fixes the issue. Hope it gets merged! |
bluebill1049
approved these changes
May 4, 2024
rafaelcalhau
pushed a commit
to rafaelcalhau/react-hook-form
that referenced
this pull request
May 5, 2024
…ect (react-hook-form#11831) * fix: correct type of `error` field in `getFieldState` return object * fix: update reports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #11814.
I changed the type of the
errorfield inside the return object of a form'sgetFieldStateto be more general. The current implementation doesn't account for nested errors inside objects since it uses the basicFieldErrortype. I changed it to an indexed access type that uses the type of the actual errors object present in the form state, which itself accounts for nested objects.