fix: remove propTypes import in prod build #3085
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove prop-types imported to prod build
import PropTypes from ‘prop-types’
The above gets added in the prod build.
transform-react-remove-prop-types
in the babel config removes the propTypes added but fails to remove the propTypes imported at the top of the scope.It requires
removeImport: true
configuration intransform-react-remove-prop-types
to be able to remove the propTypes import at the top of scopeSteps to reproduce
Add @babel/cli package to be able to test the babel config.
npm install @babel/cli --save-dev
(or)
yarn add -D @babel/cli
Set the NODE_ENV to production
This is required to test the configs for production
export NODE_ENV=production
Choose a file that you would like test
I have chosen the
index.js
file inapp/containers/HomePage
directoryUse babel to execute the file
npx babel app/containers/HomePage/index.js
Screenshots
With dev branch
With changes fixed in PR