Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcs: add support for several system metadata keys #7721

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

antiacus
Copy link

@antiacus antiacus commented Apr 4, 2024

What is the purpose of this change?

The branch adds support for six system GCS metadata keys in metadata filters (refer to https://rclone.org/filtering/#metadata):

  • cache-control (Specifies directives for caches along the request/response chain.)
  • content-disposition (Suggests a default filename for downloaded content or indicates how the content should be displayed.)
  • content-encoding (Informs the recipient how to decode the content to obtain the original data.)
  • content-language (Indicate the language of the textual content in the response.)
  • content-type (Indicates the media type or MIME type of the resource in the HTTP message's body.)
  • tier (Storage class of the object.)

The implementation is very similar to the one for the S3 backend.

Was the change discussed in an issue or in the forum before?

No, I haven't seen such disucussions at least.

Checklist

  • I have read the contribution guidelines.
  • I have added tests for all changes in this PR if appropriate.
  • I have added documentation for the changes if appropriate.
  • All commit messages are in house style.
  • I'm done, this Pull Request is ready for review :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant