Add button-{primary, secondary, anchor}-active-color controls to demo/style picker site #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, sorry to bother but any update on this? I think it would be a really helpful (and easy) addition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current demo website doesn't have a setting/color picker field for the
button-primary-active-color,button-secondary-active-color, andbutton-anchor-active-colorcss variables, leading it to be very confusing for why there's no way to style a button's color when pressed. This fixes that issue with a few lines changed in one of the demo site's config files, which adds each input field to the correct spot and pre-populates with the correct colors per builtin theme. I hope this will save a future person a good amount of debugging time. Thanks!Note: I don't know this project's preferred build/release process so I left the build for the demo unchanged. Please let me know if you'd like me to re-build it before a merge.