Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #69 #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pierreericgarcia
Copy link

next is actually the second parameter of the onPress callback function !

As pointed out in the issue 69, when we try to use the next function in the onPress callback we get an error : next is not a function. Because the first argument of the onPress callback function is actually a ref !

As we can at the line 160 of the file components/AwesomeButtonProgress/index.js :

action(this.content, this.endLoading.bind(this));

The next function is actually the second argument ! As it would be a breaking change to swap the argument order I propose to update the documentation which is misleading.

…unction is the second argument and not the first as showed in the current documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant