[ci][microcheck/13] reuse the logic to determine microcheck tests #45504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can-anyscale
force-pushed
the
can-mcx12
branch
2 times, most recently
from
d535dc2
to
bf3907a
Compare
can-anyscale
force-pushed
the
can-mcx13
branch
2 times, most recently
from
91a4bb8
to
bca5449
Compare
can-anyscale
force-pushed
the
can-mcx13
branch
3 times, most recently
from
a030647
to
8705ac3
Compare
aslonnie
approved these changes
May 24, 2024
| @@ -198,33 +198,52 @@ def gen_from_s3(cls, prefix: str): | |||
| ] | |||
|
|
|||
| @classmethod | |||
| def gen_high_impact_tests(cls, prefix: str) -> Dict[str, List]: | |||
| def gen_microcheck_step_ids(cls, prefix: str, bazel_workspace_dir: str) -> Set[str]: | |||
There was a problem hiding this comment.
maybe add docstring about what this method does?
| high_impact_tests = _get_high_impact_test_targets( | ||
| team, operating_system, container | ||
| ) | ||
| prefix = f"{operating_system}:" |
There was a problem hiding this comment.
maybe update the comment before this line about the union of new tests?
|
added comments; test all microcheck tests: https://buildkite.com/ray-project/microcheck/builds/592 |
can-anyscale
force-pushed
the
can-mcx13
branch
2 times, most recently
from
00d2f89
to
914bad4
Compare
Test class Signed-off-by: can <[email protected]>
Test class Signed-off-by: can <[email protected]>
Signed-off-by: can <[email protected]>
Signed-off-by: can <[email protected]>
can-anyscale
force-pushed
the
can-mcx13
branch
2 times, most recently
from
68757b3
to
c6c69c4
Compare
Signed-off-by: can <[email protected]>
can-anyscale
force-pushed
the
can-mcx13
branch
3 times, most recently
from
4682bb7
to
52d799f
Compare
falls there; until we can figure out something better Signed-off-by: can <[email protected]>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
…y-project#45504) Currently the logic to determine the list of microcheck tests and their rayci step ids are diverging. This PR move more function into Test class, so we converge more these two logic. This make sure that we will trigger the right buildkite steps to cover most if not all microcheck tests. Test: - CI --------- Signed-off-by: can <[email protected]> Signed-off-by: Ryan O'Leary <[email protected]>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
…y-project#45504) Currently the logic to determine the list of microcheck tests and their rayci step ids are diverging. This PR move more function into Test class, so we converge more these two logic. This make sure that we will trigger the right buildkite steps to cover most if not all microcheck tests. Test: - CI --------- Signed-off-by: can <[email protected]> Signed-off-by: Ryan O'Leary <[email protected]>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
…y-project#45504) Currently the logic to determine the list of microcheck tests and their rayci step ids are diverging. This PR move more function into Test class, so we converge more these two logic. This make sure that we will trigger the right buildkite steps to cover most if not all microcheck tests. Test: - CI --------- Signed-off-by: can <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the logic to determine the list of microcheck tests and their rayci step ids are diverging. This PR move more function into Test class, so we converge more these two logic.
This make sure that we will trigger the right buildkite steps to cover most if not all microcheck tests.
Test: