[core] NodeManager: code refactor and cleanup #45260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongchaodeng
changed the title
hongchaodeng
force-pushed
the
fix-nm-comment
branch
from
06c254e
to
5c23d07
Compare
hongchaodeng
changed the title
hongchaodeng
force-pushed
the
fix-nm-comment
branch
3 times, most recently
from
96cd408
to
69bb5bc
Compare
hongchaodeng
changed the title
hongchaodeng
force-pushed
the
fix-nm-comment
branch
3 times, most recently
from
59e85c7
to
cab83a9
Compare
hongchaodeng
force-pushed
the
fix-nm-comment
branch
from
cab83a9
to
6903ec4
Compare
Signed-off-by: hongchaodeng <[email protected]>
hongchaodeng
force-pushed
the
fix-nm-comment
branch
from
6903ec4
to
bb9ea4a
Compare
jjyao
approved these changes
May 13, 2024
src/ray/raylet/node_manager.h
Outdated
| @@ -196,7 +191,7 @@ class NodeManager : public rpc::NodeManagerServiceHandler, | |||
| /// \param object_ids The object ids to store error messages into. | |||
| /// \param job_id The optional job to push errors to if the writes fail. | |||
| void MarkObjectsAsFailed(const ErrorType &error_type, | |||
| const std::vector<rpc::ObjectReference> object_ids, | |||
| std::vector<rpc::ObjectReference> object_ids, | |||
There was a problem hiding this comment.
Change this to const &?
Also need to update in node_manager.cc as well
src/ray/raylet/raylet.cc
Outdated
| @@ -100,11 +100,13 @@ Raylet::Raylet(instrumented_io_context &main_service, | |||
|
|
|||
| // Setting up autoscaler related fields from ENV | |||
| auto instance_id = std::getenv(kNodeCloudInstanceIdEnv); | |||
| self_node_info_.set_instance_id(instance_id ? instance_id : ""); | |||
There was a problem hiding this comment.
I think the old way is actually preferred for checking whether pointer is nullptr: https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es87-dont-add-redundant--or--to-conditions
Signed-off-by: hongchaodeng <[email protected]>
hongchaodeng
force-pushed
the
fix-nm-comment
branch
from
7da2f5b
to
9465bd5
Compare
Signed-off-by: hongchaodeng <[email protected]>
Signed-off-by: hongchaodeng <[email protected]>
|
@jjyao Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.