[release-automation] More flexibility on the pipeline #45254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: khluu <[email protected]>
Signed-off-by: khluu <[email protected]>
Signed-off-by: khluu <[email protected]>
Signed-off-by: khluu <[email protected]>
Signed-off-by: khluu <[email protected]>
aslonnie
approved these changes
May 10, 2024
aslonnie
reviewed
May 10, 2024
| @@ -82,8 +92,9 @@ def download_ray_wheels_from_s3( | |||
| directory_path: The directory to download the wheels to. | |||
| """ | |||
| full_directory_path = os.path.join(bazel_workspace_dir, directory_path) | |||
|
|
|||
| wheels = _get_wheel_names(ray_version) | |||
| _, minor_version, _ = ray_version.split(".") | |||
There was a problem hiding this comment.
this might not always be 3 parts , maybe just take 2nd part without assuming it has 3 parts?
There was a problem hiding this comment.
oh ya I forgot about cases like 0.0.1.post1. Updated to just grab the 2nd part
Signed-off-by: khluu <[email protected]>
aslonnie
approved these changes
May 10, 2024
| ) | ||
|
|
||
| mock_get_wheel_names.assert_called_with(ray_version) | ||
| mock_get_wheel_names.assert_called_with(ray_version, False) |
There was a problem hiding this comment.
nit: add full_platform=False for readability?
it is actually often not recommended to use a boolean as an flag arg. a string or an enum is often more readable.
Signed-off-by: khluu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linux_x86_64,mac x86_64, andmac arm64wheels unless it's a full platform release.