[Refactor][RayCluster] Add RayClusterRedisPodAssociationOptions and HeadServiceAssociationOptions #2062
Conversation
evalaiyc98
force-pushed
the
refactor-raycluster
branch
from
7a66c22
to
84b6053
Compare
|
cc @rueian would you mind reviewing this PR? Thanks! |
evalaiyc98
force-pushed
the
refactor-raycluster
branch
from
84b6053
to
3d87528
Compare
evalaiyc98
force-pushed
the
refactor-raycluster
branch
from
3d87528
to
8858022
Compare
| func HeadServiceAssociationOptions(instance *rayv1.RayCluster) AssociationOptions { | ||
| return AssociationOptions{ | ||
| client.InNamespace(instance.Namespace), | ||
| client.MatchingLabels(HeadServiceLabels(*instance)), |
|
|
||
| if err := r.List(ctx, &services, client.InNamespace(instance.Namespace), filterLabels); err != nil { | ||
| if err := r.List(ctx, &services, common.RayClusterHeadPodsAssociationOptions(instance).ToListOptions()...); err != nil { |
There was a problem hiding this comment.
This is pretty confusing. We use RayClusterHeadPodsAssociationOptions to list service.
evalaiyc98
force-pushed
the
refactor-raycluster
branch
from
8858022
to
06652db
Compare
|
Thank you! I have revised the function names to be more well-defined and try not to confuse developers. |
evalaiyc98
force-pushed
the
refactor-raycluster
branch
2 times, most recently
from
0d06e3f
to
723a3d8
Compare
|
I intend to separate functions with similar functionality into |
| @@ -103,6 +123,13 @@ func RayServiceRayClustersAssociationOptions(rayService *rayv1.RayService) Assoc | |||
| } | |||
| } | |||
|
|
|||
| func HeadServiceAssociationOptions(instance *rayv1.RayCluster) AssociationOptions { | |||
There was a problem hiding this comment.
The function name is inconsistent with our naming convention.
| @@ -84,7 +94,7 @@ func RayClusterGroupPodsAssociationOptions(instance *rayv1.RayCluster, group str | |||
| } | |||
| } | |||
|
|
|||
| func RayClusterAllPodsAssociationOptions(instance *rayv1.RayCluster) AssociationOptions { | |||
| func RayClusterRelatedAssociationOptions(instance *rayv1.RayCluster) AssociationOptions { | |||
There was a problem hiding this comment.
What's the definition of "RayClusterRelated"?
| @@ -93,6 +103,16 @@ func RayClusterAllPodsAssociationOptions(instance *rayv1.RayCluster) Association | |||
| } | |||
| } | |||
|
|
|||
| func RayClusterServicesAssociationOptions(instance *rayv1.RayCluster) AssociationOptions { | |||
There was a problem hiding this comment.
What's the difference between this function and HeadServiceAssociationOptions?
evalaiyc98
force-pushed
the
refactor-raycluster
branch
from
8022141
to
28aed73
Compare
Why are these changes needed?
This PR aims to follow up #2045. The purpose of this initiative is to maintain consistency in association methods and avoid scattering MatchingLabels usage throughout the entire codebase.
In this PR, I mainly update the
raycluster_controller.gofile to reflect the change, and add twoAssociationOptionswhich areRayClusterRedisPodAssociationOptionsandHeadServiceAssociationOptionsinassociation.go.Related issue number
#2045
Checks