[RayJob] Improve flexibility to run specified YAML test #1844
+34
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind rebasing with the master branch? Thanks! |
evalaiyc98
force-pushed
the
rayjob-test
branch
from
23e634c
to
442913b
Compare
|
cc @rueian would you mind reviewing this PR? |
|
Sure. The changes align with the latest test_sample_raycluster_yamls.py and look good to me. So now, we skip untracked rayjob tests as well. I found this behavior is quite implicit and silent which may take some time to debug why a test never be executed. In follow-up PRs, I would recommend we also log a warning message, like the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The purpose of this PR is the same as the #1812 (comment) , aiming to enhance flexibility in executing sample YAML tests.
With this PR, it is possible to specify one or multiple sample YAML test files. If no files are specified, the test will run on all sample YAML tests related to RayJob.
After the parameter
--yaml-files, use the filename of the YAML for testing. Here's an example:[Default] Run all YAML files.
python3 tests/test_sample_rayjob_yamls.pySpecified a single YAML file.
python3 tests/test_sample_rayjob_yamls.py --yaml-files ray_v1alpha1_rayjob.yamlYou can also specify multiple YAML files:
python3 tests/test_sample_rayjob_yamls.py --yaml-files ray_v1alpha1_rayjob.yaml ray-job.custom-head-svc.yamlIn summary, this PR can save developers time and provide more flexible testing options.
Related issue number
#1812 (comment)
Checks
Following is the screenshot of manual test
[Default] Run all YAML files.
Specified two YAML files.
