Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] [CLI] Add arm64 arch build for kuberay and output should should ignore by git #1821

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Feature] [CLI] Add arm64 arch build for kuberay and output should should ignore by git #1821

wants to merge 1 commit into from
+12 −3

Conversation

jiwq
Copy link

@jiwq jiwq commented Jan 10, 2024

Why are these changes needed?

  • Support the arm64 arch
  • The kuberay executable file should be ignored, if not it will bring troubles for developers

Related issue number

Closes #1819

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@jiwq jiwq changed the title [Feature] [CLI] Add arm64 arch build for kuberay and output should ig… [Feature] [CLI] Add arm64 arch build for kuberay and output should should ignore by git Jan 10, 2024
@kevin85421
Copy link
Member

kevin85421 commented Jan 10, 2024 •
edited

Hi @jiwq, the CLI module is no longer maintained and will soon be deprecated, as mentioned in #1573. The only feature we still need from it is make release, which isn’t directly related to the CLI but is currently located there. I’ll merge #1573 after this PR is merged and relocate make release to a more appropriate place.

@kevin85421 kevin85421 self-requested a review January 10, 2024 18:37
@kevin85421 kevin85421 self-assigned this Jan 10, 2024
kevin85421
kevin85421 reviewed Jan 10, 2024
View reviewed changes
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kuberay executable file should be ignored, if not it will bring troubles for developers

Could you share more details about this? Additionally, could you provide more information on how you verified this PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@kevin85421 kevin85421

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] [CLI] Add arm64 arch build for kuberay and output should ignore by git
2 participants
@jiwq @kevin85421