[Refactor] Move MatchingLabels to association.go

[rueian]

Following the PR #1948 and #2023,

We like to move all MatchingLabels to the association.go, so that we can maintain consistency in the association methods by not scattering MatchingLabels everywhere.

This issue is a todo list for tracking refactor progress and collaboration with other contributors.

• kuberay/ray-operator/controllers/ray/raycluster_controller.go

  Line 441 in bbb65b4

  filterLabels := client.MatchingLabels{utils.RayClusterLabelKey: instance.Name}

• kuberay/ray-operator/controllers/ray/raycluster_controller.go

  Line 476 in bbb65b4

  filterLabels := client.MatchingLabels{utils.RayClusterLabelKey: instance.Name}

• kuberay/ray-operator/controllers/ray/raycluster_controller.go

  Line 509 in bbb65b4

  filterLabels := client.MatchingLabels{utils.RayClusterLabelKey: instance.Name, utils.RayNodeTypeLabelKey: string(rayv1.HeadNode)}

• kuberay/ray-operator/controllers/ray/raycluster_controller.go

  Line 1252 in bbb65b4

  filterLabels := client.MatchingLabels{utils.RayClusterLabelKey: newInstance.Name}

• kuberay/ray-operator/controllers/ray/raycluster_controller.go

  Line 1305 in bbb65b4

  filterLabels := client.MatchingLabels{utils.RayClusterLabelKey: instance.Name, utils.RayNodeTypeLabelKey: string(rayv1.HeadNode)}

• kuberay/ray-operator/controllers/ray/raycluster_controller.go

  Line 1319 in bbb65b4

  filterLabels := client.MatchingLabels(common.HeadServiceLabels(*instance))

• kuberay/ray-operator/controllers/ray/raycluster_controller.go

  Line 1340 in bbb65b4

  filterLabels := client.MatchingLabels{

• kuberay/ray-operator/controllers/ray/rayservice_controller.go

  Line 436 in bbb65b4

  filterLabels := client.MatchingLabels{

• kuberay/ray-operator/controllers/ray/rayservice_controller.go

  Line 1232 in bbb65b4

  filterLabels := client.MatchingLabels{utils.RayClusterLabelKey: instance.Name, utils.RayNodeTypeLabelKey: string(rayv1.HeadNode)}

• kuberay/ray-operator/controllers/ray/rayjob_controller_suspended_test.go

  Line 168 in bbb65b4

  listResourceFunc(ctx, &workerPods, client.MatchingLabels{

• kuberay/ray-operator/controllers/ray/rayjob_controller_suspended_test.go

  Line 181 in bbb65b4

  client.MatchingLabels{

• kuberay/ray-operator/controllers/ray/suite_helpers_test.go

  Line 210 in bbb65b4

  headFilterLabels := client.MatchingLabels{

• kuberay/ray-operator/controllers/ray/rayjob_controller_test.go

  Line 174 in bbb65b4

  workerFilterLabels := client.MatchingLabels{utils.RayClusterLabelKey: rayCluster.Name, utils.RayNodeGroupLabelKey: rayCluster.Spec.WorkerGroupSpecs[0].GroupName}

• kuberay/ray-operator/controllers/ray/rayjob_controller_test.go

  Line 182 in bbb65b4

  headFilterLabels := client.MatchingLabels{utils.RayClusterLabelKey: rayCluster.Name, utils.RayNodeGroupLabelKey: utils.RayNodeHeadGroupLabelValue}

• kuberay/ray-operator/controllers/ray/rayservice_controller_test.go

  Line 250 in bbb65b4

  filterLabels := client.MatchingLabels{utils.RayClusterLabelKey: myRayService.Status.ActiveServiceStatus.RayClusterName, utils.RayNodeGroupLabelKey: "small-group"}

• kuberay/ray-operator/controllers/ray/raycluster_controller_fake_test.go

  Line 2253 in bbb65b4

  client.MatchingLabels{

• kuberay/ray-operator/controllers/ray/raycluster_controller_fake_test.go

  Line 2264 in bbb65b4

  client.MatchingLabels{

@evalaiyc98 is already working on the suite_helpers_test.go part. cc @kevin85421

[rueian]

Appendix: Here is a MatchingLabels association diagram I previously figured out. Hope that can help someone who is interested in how CRD controllers associate each CR.