Add systemd-boot bootchooser #1367
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obbardc
changed the title
obbardc
changed the title
obbardc
force-pushed
the
wip/obbardc/systemd-boot-bootchooser
branch
2 times, most recently
from
a5fa810
to
021b534
Compare
obbardc
commented
Mar 21, 2024
| } | ||
|
|
||
| /* Set the default boot choice to this slot name */ | ||
| /* TODO: allow the slot name to be configurable */ |
There was a problem hiding this comment.
Should add a config option for this.
There was a problem hiding this comment.
Shouldn't this be the slot's bootname?
Add some really basic support to set the EFI variable for systemd-boot's default boot choice EFI variable. This is currently set when `rauc status mark-good` is called; meaning that once the system has started successfully the default boot choice EFI variable will be updated to reflect from the next boot onwards. Signed-off-by: Christopher Obbard <[email protected]>
obbardc
force-pushed
the
wip/obbardc/systemd-boot-bootchooser
branch
from
021b534
to
6c89078
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1367 +/- ##
==========================================
- Coverage 79.95% 79.87% -0.08%
==========================================
Files 67 67
Lines 20057 20082 +25
==========================================
+ Hits 16037 16041 +4
- Misses 4020 4041 +21 ☔ View full report in Codecov by Sentry. |
|
How would this interact with https://systemd.io/AUTOMATIC_BOOT_ASSESSMENT/, which is also implemented by systemd-boot? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some really basic support to set the EFI variable for systemd-boot's default boot choice EFI variable.
This is currently set when "rauc status mark-good" is called; meaning that once the system has started successfully the default boot choice EFI variable will be updated to reflect from the next boot onwards.
This PR needs (at least):
r_boot_get_state,r_boot_get_primary,r_boot_set_primaryFor context, this is from a project which we converted to use
systemd-bootfor its bootloader and is working quite well. I am creating a draft PR to see if there is any interest in accepting this into upstream, I can do all of the work to get it in.