add support for artifacts (separate applications/containers/data files) #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jluebbe
added
enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+483
to
+490
| // FIXME acl/xattr seems broken in fakeroot, perhaps use pseudo | ||
| //g_ptr_array_add(args, g_strdup("--acl")); | ||
| //g_ptr_array_add(args, g_strdup("--selinux")); | ||
| //g_ptr_array_add(args, g_strdup("--xattrs")); |
Check notice
Code scanning / CodeQL
Commented-out code Note
| g_ptr_array_add(args, g_strdup("-all-root")); | ||
| g_ptr_array_add(args, g_strdup("-no-xattrs")); | ||
| } | ||
| //g_ptr_array_add(args, g_strdup("-quiet")); |
Check notice
Code scanning / CodeQL
Commented-out code Note
| } | ||
|
|
||
| /* update links (commit) */ | ||
| g_assert(artifact->repo->parent_class == NULL); /* FIXME handle repos with parents, here or somewhere else */ |
Check notice
Code scanning / CodeQL
FIXME comment Note
| fixture->repo->description = g_strdup("desc"); | ||
| fixture->repo->path = g_build_filename(fixture->tmpdir, "repo", NULL); | ||
| fixture->repo->type = g_strdup("dummy"); | ||
| fixture->repo->data_directory = g_build_filename(fixture->tmpdir, "repo", ".data", NULL); /* FIXME Should this have a fixed path? */ |
Check notice
Code scanning / CodeQL
FIXME comment Note
| } | ||
| } | ||
|
|
||
| /* FIXME return full path? */ |
Check notice
Code scanning / CodeQL
FIXME comment Note
Comment on lines
+1345
to
+1350
| //g_message("Updating status for repo '%s'", plan->target_repo->name); | ||
| //if (!r_slot_status_save(plan->target_slot, &ierror)) { | ||
| // g_propagate_prefixed_error(error, ierror, "Error while writing status file: "); | ||
| // return FALSE; | ||
| //} |
Check notice
Code scanning / CodeQL
Commented-out code Note
| @@ -222,8 +224,148 @@ | |||
| g_clear_pointer(&filepath, g_free); | |||
| } | |||
|
|
|||
| static void check_artifacts(RaucBundle *bundle, BundleData *data) | |||
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
We currently prepare the env variables for subprocesses and shell-parsable output separately. To unify them, handle the shell quoting at the end, during collection into a string. Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
This improves the isolation between test cases. Signed-off-by: Jan Luebbe <[email protected]>
This will allow adding the Artifact Repository documentation on the same level as Slots. Signed-off-by: Jan Luebbe <[email protected]>
For now, just add the helper, but don't enable it yet. Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
These are mainly useful when combined with streaming, so we don't need to support the in the old plain bundle format. Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
Perhaps we want to make this configurable later or redirect the output to a log file. Signed-off-by: Jan Luebbe <[email protected]>
Follow-up commits will add tests and integration into the existing code. Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
With artifiact repos, this could happen by having a slot and artifact repo with the same class. Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
…s API Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
This will help avoid issues cause by running 'rauc bundle' multiple times on the same input dir. If this breaks current workflows, we may need to create a temporary copy of the bundle input directory. Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
Signed-off-by: Jan Luebbe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the concept we described in #969, but has changed a bit.